Adding compatibility with tensorflow2 #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 74.48% 73.09% -1.39%
==========================================
Files 21 21
Lines 2038 2078 +40
==========================================
+ Hits 1518 1519 +1
- Misses 520 559 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
.github/workflows/main.yml
Outdated
| strategy: | ||
| matrix: | ||
| python-version: [3.6, 3.7] |
There was a problem hiding this comment.
Shouldn't we add python 3.8?
https://www.tensorflow.org/install/pip
There was a problem hiding this comment.
Yes, we should. I'll add it.
| pip install DCASE-models[keras_tf] # for tensorflow 1 CPU-only version | ||
| pip install DCASE-models[keras_tf_gpu] # for tensorflow 1 GPU version | ||
| pip install DCASE-models[tf2] # for tensorflow 2 |
| 'sox==1.3.7', | ||
| 'sed_eval==0.2.1', | ||
| 'numpy>=1.1', | ||
| 'pandas>=0.25', |
There was a problem hiding this comment.
Do we still need pandas?
There was a problem hiding this comment.
No, we have to implement a read_csv function which is the only thing we are using from pandas (see #18 )
This PR is related to #11 and #7. With this implementation, we maintain compatibility with tensorflow 1 and 2.